Skip to content

tsan-ignores-arc-locks.swift: post process test binary on Darwin #66308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented Jun 2, 2023

This allows the DYLD_LIBRARY_PATH override to work as expected and avoid crashes when running.

Addresses rdar://108188149

This allows the `DYLD_LIBRARY_PATH` override to work as expected and
avoid crashes when running.

Addresses rdar://108188149
@edymtt edymtt requested review from yln and etcwilde June 2, 2023 20:53
@edymtt
Copy link
Contributor Author

edymtt commented Jun 2, 2023

@swift-ci please test

@edymtt
Copy link
Contributor Author

edymtt commented Jun 2, 2023

@swift-ci please test toolchain

@edymtt
Copy link
Contributor Author

edymtt commented Jun 2, 2023

@swift-ci please test Apple Silicon

Copy link
Contributor

@Catfish-Man Catfish-Man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edymtt
Copy link
Contributor Author

edymtt commented Jun 5, 2023

macOS PR failures look unrelated to this PR

diff --recursive --exclude '.*' --context=0 /var/folders/sz/hvcsl7r53m3_n5l152_210c80000gn/T/tmp4ff_9le4/SwiftSyntax/generated/syntaxNodes/SyntaxDeclNodes.swift /Users/ec2-user/jenkins/workspace/swift-pr-arm64-macos/branch-main/swift-syntax/Sources/SwiftSyntax/generated/syntaxNodes/SyntaxDeclNodes.swift
*** /var/folders/sz/hvcsl7r53m3_n5l152_210c80000gn/T/tmp4ff_9le4/SwiftSyntax/generated/syntaxNodes/SyntaxDeclNodes.swift	Fri Jun  2 22:53:30 2023
--- /Users/ec2-user/jenkins/workspace/swift-pr-arm64-macos/branch-main/swift-syntax/Sources/SwiftSyntax/generated/syntaxNodes/SyntaxDeclNodes.swift	Fri Jun  2 20:59:07 2023
***************
*** 1515 ****
!   /// Adds the provided `element` to the node's `attributes`
--- 1515 ----
!   /// Adds the provided `Attribute` to the node's `attributes`
***************
*** 1553 ****
!   /// Adds the provided `element` to the node's `modifiers`
--- 1553 ----
!   /// Adds the provided `Modifier` to the node's `modifiers`
FAIL: code-generated files committed to repository do not match generated ones. Please re-generate the code-generated-files using the following command, open a PR to the SwiftSyntax project and merge it alongside the main PR.$ swift-syntax/build-script.py generate-source-code --toolchain /path/to/toolchain.xctoolchain/usr

@edymtt
Copy link
Contributor Author

edymtt commented Jun 5, 2023

@swift-ci please test Apple Silicon

@edymtt
Copy link
Contributor Author

edymtt commented Jun 5, 2023

@swift-ci please test macOS

@edymtt
Copy link
Contributor Author

edymtt commented Jun 5, 2023

@swift-ci please build toolchain

@edymtt edymtt merged commit 44a4097 into swiftlang:main Jun 5, 2023
@edymtt edymtt deleted the postprocess-tsan-ignores-arc-locks-on-darwin branch June 5, 2023 19:42
edymtt added a commit to edymtt/swift that referenced this pull request Jun 5, 2023
This allows the `DYLD_LIBRARY_PATH` override to work as expected and
avoid crashes when running.

*Scope:* change in a Swift validation test

*Issue:* rdar://110272079

*Risk:* Low -- other standard library tests are using the same post process test

*Testing:* execute the toolchain PR job to exercise this test

(cherry picked from commit 44a4097,
 swiftlang#66308)
edymtt added a commit to edymtt/swift that referenced this pull request Jun 5, 2023
This allows the `DYLD_LIBRARY_PATH` override to work as expected and
avoid crashes when running.

*Scope:* change in a Swift validation test

*Issue:* rdar://110272889

*Risk:* Low -- other standard library tests are using the same post process test

*Testing:* execute the toolchain PR job to exercise this test

(cherry picked from commit 44a4097,
 swiftlang#66308)
edymtt added a commit that referenced this pull request Jun 7, 2023
#66346)

This allows the `DYLD_LIBRARY_PATH` override to work as expected and
avoid crashes when running.

*Scope:* change in a Swift validation test

*Issue:* rdar://110272079

*Risk:* Low -- other standard library tests are already using the same post process step

*Testing:* execute the toolchain PR job to exercise this test

(cherry picked from commit 44a4097,
 #66308)
edymtt added a commit that referenced this pull request Jun 7, 2023
#66347)

This allows the `DYLD_LIBRARY_PATH` override to work as expected and
avoid crashes when running.

*Scope:* change in a Swift validation test

*Issue:* rdar://110272889

*Risk:* Low -- other standard library tests are already using the same post process step

*Testing:* execute the toolchain PR job to exercise this test

(cherry picked from commit 44a4097,
 #66308)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants