-
Notifications
You must be signed in to change notification settings - Fork 10.5k
tsan-ignores-arc-locks.swift: post process test binary on Darwin #66308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
edymtt
merged 1 commit into
swiftlang:main
from
edymtt:postprocess-tsan-ignores-arc-locks-on-darwin
Jun 5, 2023
Merged
tsan-ignores-arc-locks.swift: post process test binary on Darwin #66308
edymtt
merged 1 commit into
swiftlang:main
from
edymtt:postprocess-tsan-ignores-arc-locks-on-darwin
Jun 5, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the `DYLD_LIBRARY_PATH` override to work as expected and avoid crashes when running. Addresses rdar://108188149
@swift-ci please test |
@swift-ci please test toolchain |
@swift-ci please test Apple Silicon |
Catfish-Man
approved these changes
Jun 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
macOS PR failures look unrelated to this PR
|
@swift-ci please test Apple Silicon |
@swift-ci please test macOS |
@swift-ci please build toolchain |
edymtt
added a commit
to edymtt/swift
that referenced
this pull request
Jun 5, 2023
This allows the `DYLD_LIBRARY_PATH` override to work as expected and avoid crashes when running. *Scope:* change in a Swift validation test *Issue:* rdar://110272079 *Risk:* Low -- other standard library tests are using the same post process test *Testing:* execute the toolchain PR job to exercise this test (cherry picked from commit 44a4097, swiftlang#66308)
edymtt
added a commit
to edymtt/swift
that referenced
this pull request
Jun 5, 2023
This allows the `DYLD_LIBRARY_PATH` override to work as expected and avoid crashes when running. *Scope:* change in a Swift validation test *Issue:* rdar://110272889 *Risk:* Low -- other standard library tests are using the same post process test *Testing:* execute the toolchain PR job to exercise this test (cherry picked from commit 44a4097, swiftlang#66308)
edymtt
added a commit
that referenced
this pull request
Jun 7, 2023
#66346) This allows the `DYLD_LIBRARY_PATH` override to work as expected and avoid crashes when running. *Scope:* change in a Swift validation test *Issue:* rdar://110272079 *Risk:* Low -- other standard library tests are already using the same post process step *Testing:* execute the toolchain PR job to exercise this test (cherry picked from commit 44a4097, #66308)
edymtt
added a commit
that referenced
this pull request
Jun 7, 2023
#66347) This allows the `DYLD_LIBRARY_PATH` override to work as expected and avoid crashes when running. *Scope:* change in a Swift validation test *Issue:* rdar://110272889 *Risk:* Low -- other standard library tests are already using the same post process step *Testing:* execute the toolchain PR job to exercise this test (cherry picked from commit 44a4097, #66308)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the
DYLD_LIBRARY_PATH
override to work as expected and avoid crashes when running.Addresses rdar://108188149