Skip to content

[5.8] tsan-ignores-arc-locks.swift: post process test binary on Darwin #66347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented Jun 5, 2023

This allows the DYLD_LIBRARY_PATH override to work as expected and avoid crashes when running.

Scope: change in a Swift validation test

Issue: rdar://110272889

Risk: Low -- other standard library tests are already using the same post process step

Testing: execute the toolchain PR job to exercise this test

(cherry picked from commit 44a4097,
#66308)

This allows the `DYLD_LIBRARY_PATH` override to work as expected and
avoid crashes when running.

*Scope:* change in a Swift validation test

*Issue:* rdar://110272889

*Risk:* Low -- other standard library tests are using the same post process test

*Testing:* execute the toolchain PR job to exercise this test

(cherry picked from commit 44a4097,
 swiftlang#66308)
@edymtt edymtt requested a review from Catfish-Man June 5, 2023 20:08
@edymtt edymtt requested a review from a team as a code owner June 5, 2023 20:08
@edymtt
Copy link
Contributor Author

edymtt commented Jun 5, 2023

@swift-ci please test

@edymtt
Copy link
Contributor Author

edymtt commented Jun 5, 2023

@swift-ci please test Apple Silicon

@edymtt
Copy link
Contributor Author

edymtt commented Jun 5, 2023

@swift-ci please build toolchain

@edymtt edymtt merged commit 052c9a4 into swiftlang:release/5.8 Jun 7, 2023
@edymtt edymtt deleted the postprocess-tsan-ignores-arc-locks-on-darwin-5.8 branch June 7, 2023 15:10
@edymtt edymtt added swift 5.8 🍒 release cherry pick Flag: Release branch cherry picks labels Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants