Add flags to toolchain Info.plist to allow using macros from Apple's SDKs with an open-source toolchain when building in Xcode #66365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please build toolchain |
owenv
force-pushed
the
pr/ovoorhees/macro-settings
branch
from
599493d to
999bf66
Compare
|
fixed typo @swift-ci please build toolchain macOS |
…SDKs when building in Xcode
owenv
force-pushed
the
pr/ovoorhees/macro-settings
branch
from
999bf66 to
5a7ba23
Compare
|
fixed one more escaping issue @swift-ci please build toolchain macOS |
|
Verified that https://ci.swift.org/job/swift-PR-toolchain-macos/728/artifact/branch-main/swift-PR-66365-728-osx.tar.gz contains the correct Info.plist content, and that using macros from the SDK works in Xcode 15 beta with this toolchain selected. Also verified that the unknown frontend flags are correctly ignored when building using Xcode 14.3 |
|
@swift-ci please smoke test |
|
Adding @shahmishal since this affects the swift.org toolchains |
shahmishal
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the required build settings overrides to the toolchain's info.plist to allow loading macros from the Xcode default toolchain