[5.9] Add flags to toolchain Info.plist to allow using macros from Apple's SDKs when building in Xcode using swift.org toolchains #66427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SDKs when building in Xcode
|
@swift-ci please build toolchain macOS |
|
@swift-ci please smoke test |
|
@swift-ci Please test |
DougGregor
approved these changes
Jun 7, 2023
shahmishal
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.9 cherrypick of #66365
Explanation: Adds settings overrides to the toolchain Info.plist so that when using a swift.org toolchain to build in Xcode, macros shipped with Apple SDKs can be used.
Risk: Low. Changes are restricted to the toolchain's Info.plist overriding build settings, and the flags injected are strictly additive.
Original PR: #66365
Reviewed by: @shahmishal
Resolves: rdar://109061058
Tests: Manually verified this change is a no-op in Xcode 14.3, and that in Xcode 15 beta it allows use of SDK macros while still allowing projects to add their own flags using OTHER_SWIFT_FLAGS.