[Index] Include generic macro arguments #66944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
requested review from
ahoppen,
rintaro,
hborla,
slavapestov and
xedin
as code owners
bnbarham
force-pushed
the
index-macro-generics
branch
from
c9b22be to
e646fc5
Compare
|
@swift-ci please test |
rintaro
approved these changes
Jun 27, 2023
bnbarham
force-pushed
the
index-macro-generics
branch
2 times, most recently
from
68501c7 to
de0eccb
Compare
`ASTWalker` was missing a walk into the generic arguments for freestanding declarations and expressions. `SemaAnnotator` was missing the walk into the `TypeRepr` when walking over custom attributes. Resolves rdar://110856428.
bnbarham
force-pushed
the
index-macro-generics
branch
from
de0eccb to
9bc26cb
Compare
|
@swift-ci please test |
hamishknight
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASTWalkerwas missing a walk into the generic arguments for freestanding declarations and expressions.SemaAnnotatorwas missing the walk into theTypeReprwhen walking over custom attributes.Resolves rdar://110856428.