[5.9][Index] Include generic macro arguments #66968
Merged
+50
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bnbarham
commented
Jun 28, 2023
bnbarham
commented
- Explanation: Adds missing generic arguments to the index.
- Scope: Index
- Risk: Low, adds new references to the index. There's a small risk that the ASTWalker have an impact outside of indexing, but testing should pick that up.
- Testing: New index tests for macro expansion generic arguments.
- Original PR: [Index] Include generic macro arguments #66944
`ASTWalker` was missing a walk into the generic arguments for freestanding declarations and expressions. `SemaAnnotator` was missing the walk into the `TypeRepr` when walking over custom attributes. Resolves rdar://110856428. (cherry picked from commit 9bc26cb)
bnbarham
added
🍒 release cherry pick
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
DougGregor
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.