[cxx-interop] Avoid linker errors for multiple instantiations of a templated struct with non-type parameters #66957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorzhdan
requested review from
zoecarver,
hyp,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/cxx-template-mangling
branch
from
9a10336 to
9f51018
Compare
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/cxx-template-mangling
branch
from
9f51018 to
043a120
Compare
|
@swift-ci please smoke test |
…mplated struct with non-type parameters When mangling the name of a C++ template specialization, we currently ignore non-type templated parameter. This causes two different instantiations of the same templated type to have the same mangled name, triggering linker errors. This change makes sure we mangle all of the templated parameters by relying on Clang mangling logic. rdar://107757051
egorzhdan
force-pushed
the
egorzhdan/cxx-template-mangling
branch
from
043a120 to
b63e9ba
Compare
|
@swift-ci please smoke test |
|
This is unnecessary after #67101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When mangling the name of a C++ template specialization, we currently ignore non-type templated parameters. This causes two different instantiations of the same templated type to have the same mangled name, triggering linker errors.
This change makes sure we mangle all of the templated parameters by relying on Clang mangling logic.
rdar://107757051