[cxx-interop] Mangle numeric template arguments #67101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/mangle-numeric-tmpl-args
branch
from
9fc88ab to
f2ae255
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test Windows |
slavapestov
reviewed
Jul 5, 2023
egorzhdan
force-pushed
the
egorzhdan/mangle-numeric-tmpl-args
branch
from
f2ae255 to
5183edf
Compare
|
@swift-ci please smoke test |
This fixes linker errors when there are multiple instantiations of a templated struct with numeric template parameters. When mangling the name of a C++ template specialization, we currently ignore non-type templated parameters. This causes two different instantiations of the same templated type to have the same mangled name, triggering linker errors. rdar://107757051
egorzhdan
force-pushed
the
egorzhdan/mangle-numeric-tmpl-args
branch
from
5183edf to
d4e8551
Compare
|
@swift-ci please smoke test |
hyp
approved these changes
Jul 5, 2023
This was referenced Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes linker errors when there are multiple instantiations of a templated struct with numeric template parameters.
When mangling the name of a C++ template specialization, we currently ignore non-type templated parameters. This causes two different instantiations of the same templated type to have the same mangled name, triggering linker errors.
rdar://107757051