Skip to content

[Runtime] Fast-path lookup of protocol descriptors with standard manglings. #66959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented Jun 27, 2023

We weren't taking advantage of standard manglings in _findProtocolDescriptor like wo do in _findContextDescriptor. Extract out the "standard mangling" code and call it from both to speed up those searches.

rdar://111235115

…lings.

We weren't taking advantage of standard manglings in _findProtocolDescriptor like wo do in _findContextDescriptor. Extract out the "standard mangling" code and call it from both to speed up those searches.

rdar://111235115
@mikeash mikeash requested a review from al45tair June 27, 2023 18:16
@mikeash
Copy link
Contributor Author

mikeash commented Jun 27, 2023

@swift-ci please test

@mikeash
Copy link
Contributor Author

mikeash commented Jun 28, 2023

@swift-ci please test macOS platform

@mikeash mikeash merged commit 811950e into swiftlang:main Jun 28, 2023
Copy link
Contributor

@al45tair al45tair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants