Skip to content

[5.9][Runtime] Fast-path lookup of protocol descriptors with standard manglings. #66961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented Jun 27, 2023

Cherry-pick #66959 to release/5.9.

We weren't taking advantage of standard manglings in _findProtocolDescriptor like wo do in _findContextDescriptor. Extract out the "standard mangling" code and call it from both to speed up those searches.

rdar://111235115

… manglings.

We weren't taking advantage of standard manglings in _findProtocolDescriptor like wo do in _findContextDescriptor. Extract out the "standard mangling" code and call it from both to speed up those searches.

rdar://111235115
(cherry picked from commit 516c21a)
@mikeash mikeash requested a review from a team as a code owner June 27, 2023 19:09
@mikeash
Copy link
Contributor Author

mikeash commented Jun 27, 2023

@swift-ci please test

@mikeash
Copy link
Contributor Author

mikeash commented Jun 27, 2023

• Description: This adds fast-path lookups for protocol descriptors with standard shorthand manglings, like we already do for other type descriptors.
• Risk: Very low. The new code should either work or fail obviously, and it's exercised thoroughly.
• Original PR: #66959
• Reviewed By: @tbkka
• Testing: Tested manually to ensure that the new fast path takes effect, and skips the descriptor scan. Existing tests thoroughly validate correctness.
• Resolves: rdar://111235115

@mikeash mikeash merged commit a69a842 into swiftlang:release/5.9 Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants