[cxx-interop] Handle inherited templated operators during auto-conformance #67287
+532
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/cxx-equal-equal
branch
from
59d7555 to
7f33e99
Compare
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/cxx-equal-equal
branch
from
7f33e99 to
52015fe
Compare
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/cxx-equal-equal
branch
from
52015fe to
42d046b
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/cxx-equal-equal
branch
from
42d046b to
d6592f7
Compare
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/cxx-equal-equal
branch
from
d6592f7 to
206a585
Compare
|
@swift-ci please smoke test |
…mance This fixes the automatic `std::unordered_map` conformance to CxxDictionary on Linux. Previously `std::unordered_map::const_iterator` was not auto-conformed to UnsafeCxxInputIterator because its `operator==` is defined on a templated base class of `const_iterator`. rdar://105220600
egorzhdan
force-pushed
the
egorzhdan/cxx-equal-equal
branch
from
206a585 to
bc56ddc
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
4 similar comments
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test Linux |
zoecarver
reviewed
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the automatic
std::unordered_mapconformance to CxxDictionary on Linux. Previouslystd::unordered_map::const_iteratorwas not auto-conformed to UnsafeCxxInputIterator because itsoperator==is defined on a templated base class ofconst_iterator.rdar://105220600
Resolves #66767