🍒[cxx-interop] Handle inherited templated operators during auto-conformance #67373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mance This fixes the automatic `std::unordered_map` conformance to CxxDictionary on Linux. Previously `std::unordered_map::const_iterator` was not auto-conformed to UnsafeCxxInputIterator because its `operator==` is defined on a templated base class of `const_iterator`. rdar://105220600 (cherry picked from commit bc56ddc)
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: This fixes the automatic
std::unordered_mapconformance to CxxDictionary on Linux. Previouslystd::unordered_map::const_iteratorwas not auto-conformed to UnsafeCxxInputIterator because itsoperator==is defined on a templated base class ofconst_iterator.Scope: This adjusts the auto-conformance logic of C++ types to Swift protocols.
Risk: Low, this only takes effect when C++ interop is enabled.
Original PR: #67287
rdar://105220600
(cherry picked from commit bc56ddc)