Skip to content

[SymbolGraphGen] don't emit symbols and protocols from unconditionally unavailable extensions #67539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

QuietMisdreavus
Copy link
Contributor

Resolves rdar://112137607

When a protocol conformance is supplied via an extension tagged with @available(*, unavailable), that protocol shouldn't be considered part of that type's API. This PR updates SymbolGraphGen to skip unconditionally-unavailable extension blocks and protocol conformances that come from them.

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please smoke test

Copy link
Contributor

@daniel-grumberg daniel-grumberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@QuietMisdreavus QuietMisdreavus merged commit 632f0a3 into main Jul 26, 2023
@QuietMisdreavus QuietMisdreavus deleted the QuietMisdreavus/unavailable-conformance branch July 26, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants