[Macros] Replace all uses of the ConformanceMacro protocol with ExtensionMacro.
#67762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
bnbarham
approved these changes
Aug 5, 2023
| return [("OptionSet", nil)] | ||
| let ext: DeclSyntax = | ||
| """ | ||
| extension \(type.trimmed): OptionSet {} |
There was a problem hiding this comment.
Do we/should we trim the type before passing it?
There was a problem hiding this comment.
I don't recall whether we do (I copied this from elsewhere), but we should if we don't already
| extension \(type.trimmed): OptionSet {} | ||
| """ | ||
|
|
||
| return [ext.cast(ExtensionDeclSyntax.self)] |
There was a problem hiding this comment.
I wonder if we should make ExtensionDeclSyntax SyntaxParseable.
hborla
force-pushed
the
remove-conformance-macro-protocol
branch
from
6d74182 to
d03ef5a
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConformanceMacroprovides a default implementation ofExtensionMacroso this is effectively NFC (and most of the changes are in tests anyway).