-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Macros] Replace all uses of the ConformanceMacro
protocol with ExtensionMacro
.
#67762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hborla
merged 1 commit into
swiftlang:main
from
hborla:remove-conformance-macro-protocol
Aug 5, 2023
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -123,27 +123,25 @@ public struct OptionSetMacro { | |
} | ||
} | ||
|
||
extension OptionSetMacro: ConformanceMacro { | ||
public static func expansion< | ||
Decl: DeclGroupSyntax, | ||
Context: MacroExpansionContext | ||
>( | ||
extension OptionSetMacro: ExtensionMacro { | ||
public static func expansion( | ||
of attribute: AttributeSyntax, | ||
providingConformancesOf decl: Decl, | ||
in context: Context | ||
) throws -> [(TypeSyntax, GenericWhereClauseSyntax?)] { | ||
// Decode the expansion arguments. | ||
guard let (structDecl, _, _) = decodeExpansion(of: attribute, attachedTo: decl, in: context) else { | ||
return [] | ||
} | ||
|
||
attachedTo decl: some DeclGroupSyntax, | ||
providingExtensionsOf type: some TypeSyntaxProtocol, | ||
conformingTo protocols: [TypeSyntax], | ||
in context: some MacroExpansionContext | ||
) throws -> [ExtensionDeclSyntax] { | ||
// If there is an explicit conformance to OptionSet already, don't add one. | ||
if let inheritedTypes = structDecl.inheritanceClause?.inheritedTypes, | ||
inheritedTypes.contains(where: { inherited in inherited.type.trimmedDescription == "OptionSet" }) { | ||
if protocols.isEmpty { | ||
return [] | ||
} | ||
|
||
return [("OptionSet", nil)] | ||
let ext: DeclSyntax = | ||
""" | ||
extension \(type.trimmed): OptionSet {} | ||
""" | ||
|
||
return [ext.cast(ExtensionDeclSyntax.self)] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wonder if we should make There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes please! |
||
} | ||
} | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we/should we trim the type before passing it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't recall whether we do (I copied this from elsewhere), but we should if we don't already