[Dependency Scanning] Implement parallel imported module resolution #68252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
force-pushed
the
ParallelScan
branch
2 times, most recently
from
02b7a4d to
edf95dd
Compare
|
@swift-ci test |
|
@swift-ci test Windows platform |
artemcm
requested review from
hborla,
slavapestov,
xedin,
zoecarver,
hyp,
egorzhdan and
tshortli
as code owners
artemcm
changed the title
|
Windows build is failing to build the refactor because we're not linking something in correctly when building |
artemcm
force-pushed
the
ParallelScan
branch
from
edf95dd to
70636cf
Compare
|
@swift-ci test |
artemcm
force-pushed
the
ParallelScan
branch
from
70636cf to
74ef02c
Compare
|
@swift-ci test |
artemcm
force-pushed
the
ParallelScan
branch
from
74ef02c to
139a56b
Compare
|
@swift-ci test |
xymus
reviewed
Sep 20, 2023
xymus
reviewed
Sep 20, 2023
| @@ -0,0 +1,150 @@ | |||
| //===--- ModuleDependencyScanner.h - Import Swift modules --------*- C++ | |||
| //-*-===// | |||
|
@swift-ci test |
…pendencyScanner' class From being a scattered collection of 'static' methods in ScanDependencies.cpp and member methods of ASTContext. This makes 'ScanDependencies.cpp' much easier to read, and abstracts the actual scanning logic away to a place with common state which will make it easier to reason about in the future.
'ModuleDependencyScanner' maintains a Thread Pool along with a pool of workers which are capable of executing a filesystem lookup of a named module dependency. When resolving imports of a given Swift module, each import's resolution operation can be issued asunchronously.
artemcm
force-pushed
the
ParallelScan
branch
from
139a56b to
b4dfb6b
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Dependency Scanning] Refactor primary scan operations into
ModuleDependencyScannerclassFrom being a scattered collection of
staticmethods in ScanDependencies.cppand member methods of
ASTContext. This makesScanDependencies.cppmuch easierto read, and abstracts the actual scanning logic away to a place with common
state which will make it easier to reason about in the future.
[Dependency Scanning] Implement parallel imported module resolution
ModuleDependencyScannermaintains a Thread Pool along with a pool of workerswhich are capable of executing a filesystem lookup of a named module dependency.
When resolving imports of a given Swift module, each import's resolution
operation can be issued asynchronously.
For the time being, the scanner is restricted to still run single-threaded, with a new frontend option
-parallel-scanenabling multi-threaded dependency scanning.