Skip to content

[Dependency Scanning] Restore propagation of -Xcc flags to scanner's Swift Textual interface-reading sub-invocation #69527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2023
Merged

[Dependency Scanning] Restore propagation of -Xcc flags to scanner's Swift Textual interface-reading sub-invocation #69527

merged 1 commit into from
Oct 31, 2023

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Oct 30, 2023

This will result in such flags being propagated to interface build command-lines for discovered Swift modules.

This functionality has been missing since:
#68252

@artemcm
[Dependency Scanning] Restore propagation of -Xcc flags to scanner'…
9eee1ec 
…s Swift Textual interface-reading sub-invocation
@artemcm artemcm requested a review from nkcsgexi October 30, 2023 23:43
@artemcm artemcm requested a review from tshortli as a code owner October 30, 2023 23:43
@artemcm
Copy link
Contributor Author

artemcm commented Oct 30, 2023

@swift-ci test

@artemcm artemcm merged commit 3168a91 into swiftlang:main Oct 31, 2023
@artemcm artemcm deleted the FixupDepScanExtraClangArgs branch October 31, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshortli tshortli tshortli approved these changes

@nkcsgexi nkcsgexi Awaiting requested review from nkcsgexi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artemcm @tshortli