Correction of assert in case a 32bits architecture is used #6838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to swift
Updating to the latest version
Updating to the latest version of swift
CodaFi
reviewed
Jan 16, 2017
| @@ -133,8 +133,14 @@ class EffectiveClangContext { | |||
| return StringRef(Unresolved.Data, UnresolvedLength); | |||
| } | |||
| }; | |||
|
|
|||
| #if __SIZEOF_POINTER__ == 4 | |||
There was a problem hiding this comment.
Nope. SIZEOF_POINTER is undefined
Use LLVM_PTR_SIZE defined in "LLVM/Support/Compiler.h"
https://github.com/llvm-mirror/llvm/blob/master/include/llvm/Support/Compiler.h
|
Could you please rebase and drop these merge commits? |
hughbe
requested changes
Jan 16, 2017
| @@ -133,8 +133,14 @@ class EffectiveClangContext { | |||
| return StringRef(Unresolved.Data, UnresolvedLength); | |||
| } | |||
| }; | |||
|
|
|||
| #if __SIZEOF_POINTER__ == 4 | |||
There was a problem hiding this comment.
Nope. SIZEOF_POINTER is undefined
Use LLVM_PTR_SIZE defined in "LLVM/Support/Compiler.h"
https://github.com/llvm-mirror/llvm/blob/master/include/llvm/Support/Compiler.h
|
Ok, I close this pull request and ask for a new one with a rebased version and using SIZEOF_POINTER. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an assert that checks the size of a type against the pointer size. This does not work on 32 bits architectures as the pointers are smaller, but the other types are not reduced acordingly.