Correction for 32 bits platforms #6845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be work making the commit description better (e.g. "Fix sizeof assertion on 32 bit platforms"): |
| static_assert(sizeof(EffectiveClangContext) <= 2 * sizeof(void *), | ||
| "should fit in a couple pointers"); | ||
| #endif |
There was a problem hiding this comment.
I wonder if we can do something more generic considering that LLVM_PTR_SIZE is equal to sizeof(void *) and we know that EffectiveClangContext should be less than or equal to 16 bytes long. Otherwise, LGTM. Nice catch!
There was a problem hiding this comment.
Maybe we shouldn't even bother. @milseman?
There was a problem hiding this comment.
(Originally I think the whole thing fit in one pointer, even on 32-bit platforms. Going from one to two is a bigger jump than two to four.)
|
@swift-ci Please smoke test |
|
Slava, please don't merge PRs with open review requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull base on the changes requested in pull #6838.