ModuleInterface: prepare to accept access-level on imports in swiftinterfaces #68523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While use of access-level in imports is still gated by a flag for normal source code, accept it in swiftinterfaces without the flag. This will make it easier for older compilers to read newer swiftinterfaces created by a future compiler where that restriction is lifted. rdar://115455383
If the access-level on imports proposal is accepted as written, all imports printed in swiftinterfaces will be `public`. Whether or not we require the explicit `public` keyword in Swift 6 mode, printing it will have no downside. It also goes along with the mentality that swiftinterfaces should be more explicit than implicit. rdar://115455383
xymus
requested review from
hborla,
slavapestov,
xedin and
artemcm
as code owners
|
@swift-ci Please smoke test |
tshortli
reviewed
Sep 14, 2023
tshortli
approved these changes
Sep 14, 2023
|
To minimize condfails I think it could be helpful to cherry pick this very targeted change back to |
artemcm
approved these changes
Sep 14, 2023
|
@swift-ci Please smoke test |
tshortli
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds forward looking support for swiftinterfaces and the Access-levels on import features. Ensure the compiler accepts future swiftinterfaces using access-level keywords on imports without the flag. And print the
publicaccess-level keyword in Swift 6 mode.