[5.10] ModuleInterface: prepare to accept access-level on imports in swiftinterfaces #68587
Conversation
While use of access-level in imports is still gated by a flag for normal source code, accept it in swiftinterfaces without the flag. This will make it easier for older compilers to read newer swiftinterfaces created by a future compiler where that restriction is lifted. rdar://115455383
If the access-level on imports proposal is accepted as written, all imports printed in swiftinterfaces will be `public`. Whether or not we require the explicit `public` keyword in Swift 6 mode, printing it will have no downside. It also goes along with the mentality that swiftinterfaces should be more explicit than implicit. rdar://115455383
|
@swift-ci Please test |
test/ModuleInterface/imports.swift
Outdated
| @@ -5,6 +5,10 @@ | |||
| // RUN: %target-swift-typecheck-module-from-interface(%t.swiftinterface) -I %S/Inputs/imports-clang-modules/ -I %t | |||
| // RUN: %FileCheck -implicit-check-not BAD %s < %t.swiftinterface | |||
|
|
|||
| /// Swift 6 variant. | |||
| // RUN: %target-swift-emit-module-interface(%t.swiftinterface) %s %S/Inputs/imports-other.swift -disable-implicit-concurrency-module-import -disable-implicit-string-processing-module-import -I %S/Inputs/imports-clang-modules/ -I %t -verify -swift-version 6 | |||
There was a problem hiding this comment.
This will fail in a non-asserts toolchain, because -swift-version 6 is only supported in the asserts toolchain (like the ones used for testing by default).
See https://github.com/apple/swift/blob/main/test/Driver/swift-version-6-asserts.swift and https://github.com/apple/swift/blob/main/test/Driver/swift-version-6-noasserts.swift for examples of how -swift-version 6 has been tested before. Other tests added REQUIRES: asserts, but that will make the full test not run in noasserts toolchains.
(Introduced in #68523 but commenting here so it doesn't propagate to another branch).
There was a problem hiding this comment.
Thanks for pointing it out. The fix is up #68591.
This allows us to limit the test to asserts compiler supporting -swift-version 6. rdar://115578753
|
@swift-ci Please test |
This adds forward looking support for swiftinterfaces and the Access-levels on import features. Ensure the compiler accepts future swiftinterfaces using access-level keywords on imports without the flag. And print the public access-level keyword in Swift 6 mode.