[Explicit Modules] Fix detection of a type-checking action in ExplicitModuleInterfaceBuilder
#68598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
approved these changes
Sep 18, 2023
|
Thank you! Could you add a test case using the blocklist mechanism instead of using |
artemcm
force-pushed
the
ExplicitInterfaceTypecheckFix
branch
from
c595801 to
901b370
Compare
nkcsgexi
approved these changes
Sep 18, 2023
|
@swift-ci smoke test and merge |
Done, thanks! |
xymus
approved these changes
Sep 18, 2023
|
@swift-ci smoke test and merge |
|
Debug build of a compiler with asserts is crashing with this change. Taking a look. |
…itModuleInterfaceBuilder' When we run an interface verification tasks with Explicit module builds, we directly invoke a '-explicit-interface-module-build' instance with a '-typecheck-module-from-interface' action. So the builder needs to recognize this as a typechecking invocation. In implicit builds, this gets lowered into a separate compiler sub-instance with a '-typecheck' action, for some reason. resolves rdar://115565571
artemcm
force-pushed
the
ExplicitInterfaceTypecheckFix
branch
from
901b370 to
373d491
Compare
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we run an interface verification tasks with Explicit module builds, we directly invoke a
-explicit-interface-module-buildinstance with a-typecheck-module-from-interfaceaction. So the builder needs to recognize this as a type-checking invocation. In implicit builds, this gets lowered into a separate compiler sub-instance with a-typecheckaction, for some reason.resolves rdar://115565571