[5.10 🍒][Explicit Modules] Fix detection of a type-checking action in 'ExplicitModuleInterfaceBuilder' #68599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
added
🍒 release cherry pick
|
@swift-ci test |
nkcsgexi
approved these changes
Sep 18, 2023
…itModuleInterfaceBuilder' When we run an interface verification tasks with Explicit module builds, we directly invoke a '-explicit-interface-module-build' instance with a '-typecheck-module-from-interface' action. So the builder needs to recognize this as a typechecking invocation. In implicit builds, this gets lowered into a separate compiler sub-instance with a '-typecheck' action, for some reason. resolves rdar://115565571
artemcm
force-pushed
the
510ExplicitInterfaceTypecheckFix
branch
from
bca3ae4 to
6bcdedf
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #68598
• Release: Swift 5.10
• Explanation: When we run an interface verification tasks with Explicit module builds, we directly invoke a '-explicit-interface-module-build' instance with a '-typecheck-module-from-interface' action. So the builder needs to recognize this as a typechecking invocation. In implicit builds, this gets lowered into a separate compiler sub-instance with a '-typecheck' action, for some reason.
• Scope of Issue: Clients who disable verification of emitted module interface will still see error diagnostics, instead of expected warnings, from verification jobs.
• Origination: Explicit Module Build feature development recently enabled explicit interface build for Interface verification jobs.
• Reviewed By: @tshortli @xymus @nkcsgexi
• Automated Testing: Test added to the compiler test suite
resolves rdar://115565571