[Concurrency] Do not allow actor isolation violations in function conversions to impact constraint solving. #68685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
…versions to impact constraint solving.
hborla
force-pushed
the
minimize-constraint-system-isolation-checking
branch
from
c01ee96 to
2e9c64d
Compare
|
@swift-ci please smoke test |
This was referenced Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to steer the constraint system away from needing to reason about actor isolation violations. Being able to determine actor isolation from an already-type-checked expression alone is a desirable property, because it may allow us to enable actor-isolated default arguments and only diagnose violations based on the caller's actor isolation. Concretely, this change will always allow function conversions that add or remove global-actor attributes in the constraint system, and violations are always diagnosed later on in the actor isolation checker. This means that the presence of a function conversion that violates actor isolation cannot impact solution ranking.