Keep certain function that are potentially used in the debugger #68843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
Currently, when compiling with no optimizations on, we still delete functions that are sometimes used in the debugger. For example, users might want to call functions which are unused, or compiler generated setters/getters. rdar://101046198
augusto2112
force-pushed
the
keep-funcs-for-deb-tests
branch
from
d359abb to
4e1ded4
Compare
|
@swift-ci test |
augusto2112
force-pushed
the
keep-funcs-for-deb-tests
branch
from
4e1ded4 to
4c89666
Compare
|
@swift-ci test |
augusto2112
requested review from
hamishknight,
zoecarver,
hyp and
egorzhdan
as code owners
Now that we keep many more functions on unoptimized builds, many tests need to be changed to either: - Account for function that wasn't being emitted before to being emitted now. - Account for functions that previously were being emitted lazily to being emitted eagerly now.
augusto2112
force-pushed
the
keep-funcs-for-deb-tests
branch
from
4c89666 to
1c4b67a
Compare
|
@swift-ci smoke test |
|
@swift-ci benchmark |
aschwaighofer
added a commit
to aschwaighofer/swift
that referenced
this pull request
Oct 24, 2023
We don't support generating code for ptrauth builtins with generic inputs (or non-constant inputs). We rely on specialization/inlining for such code to work. After a recent commit (swiftlang#68843 ) code in IRGen keeps internal unreferenced functions alive for debugging purposes. This is a problem for the generic functions in PtrAuth.swift using ptrauth builtins. Opt out of this new behavior by sprinkling some pixie dust. Fixes debug swift standard library builds targeting arm64e. rdar://117411740
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when compiling with no optimizations on, we still delete
functions that are sometimes used in the debugger. For example, users
might want to call functions which are unused, or compiler generated
setters/getters.
rdar://101046198