Ignore unknown pragma warnings with MSVC #6885
Conversation
|
@swift-ci please clean test |
| # Disable C4068: unknown pragma. This means that MSVC doesn't report hundreds of warnings across | ||
| # the repository for IDE features such as #pragma mark "Title". | ||
| check_cxx_compiler_flag("/wd4068" CXX_SUPPORTS_UNKNOWN_PRAGMA_FLAG) | ||
| append_if(CXX_SUPPORTS_UNKNOWN_PRAGMA_FLAG "/wd4068" CMAKE_CXX_FLAGS) |
There was a problem hiding this comment.
So I am having issue with this argument when I build on Mac OS X; it seems to be triggering for me (https://bugs.swift.org/browse/SR-3952) I presume this change was intended to be a MSVC only thing? Should this somehow be gated by a platform guard or perhaps be of the -wd4068 format?
There was a problem hiding this comment.
I think someone from our team was hitting this too and blowing away the CMakeCache.txt file in the Swift build directory fixed it. But maybe I'm misremembering.
There was a problem hiding this comment.
I blew away my entire build directory after this failure and still was having issues: the fix I had was to comment out these two lines and do a full clean re-build.
This is in the file
cmake/modules/SwiftSharedCMakeConfig.cmakebecause this file housesmacro(swift_common_cxx_warnings)