Fix potentially appending "/wd4068" on mac builds #7450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #6885 |
|
@swift-ci please clean smoke test |
|
Looks good; I will verify the patch tomorrow when I get back to the office and can kick off another build |
|
Perfect, you might want to run a clean build just in case CMake's cache is weird |
|
Any luck? |
|
If he doesn't get back to you by the end of the day let's just merge it. It's probably not harmful and I think someone else hit the same issue. |
|
I was able to try it out yesterday; seems like it works as expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what's causing this, I'd have thought this code works, and looks to have worked for a long time.
Anyways, fixes SR-3952
@jrose-apple @phausler