SILGen: Skip emitting distributed thunks for skipped functions #68917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
tshortli
commented
Oct 2, 2023
| // CHECK-SKIP-NONINLINE-LABEL: sil [serialized] [distributed] [ossa] @$s38distributed_thunk_skip_function_bodies2DAC13inlinableFuncyyF : $@convention(method) (@guaranteed DA) -> () { | ||
| // CHECK-SKIP-NONINLINE: function_ref @$s38distributed_thunk_skip_function_bodies9blackHoleyyxlF | ||
| // CHECK-SKIP-NONINLINE: } // end sil function '$s38distributed_thunk_skip_function_bodies2DAC13inlinableFuncyyF' | ||
| @inlinable public distributed func inlinableFunc() { |
There was a problem hiding this comment.
Does an @inlinable distributed func even make sense? I'm sort of surprised this is allowed.
There was a problem hiding this comment.
I think that's okay because we inject an implicit if/else that either dispatches remove or goes though the local logic so inlining shouldn't break thunking but it would be good to add a test for that to make sure.
There was a problem hiding this comment.
Yeah it should be fine to inline distributed thunks, they're the if-remote-do-this code
|
@swift-ci please test source compatibility debug |
tshortli
changed the title
ktoso
approved these changes
Oct 2, 2023
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Oct 26, 2023
Generalizes swiftlang#68917 to cover accessors in addition to methods. Resolves rdar://117226130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #68760 to fix a failed assertion when building the
swift-distributed-actorsproject.