[5.10][TypeChecker] Disallow use of global actor attributes of setters, add… #69369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ressors, and observers No other accessor besides a getter could be marked as async and adding @mainactor global accessor on setters and other accessor kinds would mean disconnecting them from a getter in terms of isolation, so let's keep things simple and allow global actor attribute on getters and/or enclosing declaration only. Resolves: rdar://99281333 (cherry picked from commit a71d62c)
|
@swift-ci please test |
hborla
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ressors, and observers
Cherry-pick of https://github.com/apple/swift/pull/69219/commits
No other accessor besides a getter could be marked as async and adding @mainactor global accessor on setters and other accessor kinds would mean disconnecting them from a getter in terms of isolation, so let's keep things simple and allow global actor attribute on getters and/or enclosing declaration only.
Scope: Accessor declarations with explicit global actor attribute.
Main Branch PR: https://github.com/apple/swift/pull/69219/commits
Resolves: rdar://99281333
Risk: Low
Reviewed By: @hborla
Testing: added test-cases to the test suite.
(cherry picked from commit a71d62c)