[5.10][TypeChecker] Prevent invalid attribute on accessor from failing if i… #70165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t's a warning Pre-Swift 6 use of a global actor attribute on an accessor would be diagnosed as a warning and shouldn't fail `GlobalActorAttributeRequest`. Resolves: rdar://118934711
|
@swift-ci please test |
hborla
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t's a warning
Cherry-pick of #70163
Follow-up to #69369
Pre-Swift 6 use of a global actor attribute on an accessor would be diagnosed as a warning and shouldn't fail
GlobalActorAttributeRequest.Scope: Accessors with global actor attributes in pre-Swift 6 mode.
Main Branch PR: [TypeChecker] Prevent invalid attribute on accessor from failing if i… #70163
Resolves: rdar://118934711
Risk: Low
Reviewed By: @hborla
Testing: No tests since the behavior is not currently observable.