[NoncopyableGenerics] Basic end-to-end testing (without stdlib). #69591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves rdar://117594962
We were missing some of the "artificial" types in the TypeBase::isNoncopyable implementation. Rather than add them to the frontend, I just check for those special SIL-only types in SILType::isMoveOnly. resolves rdar://117282929
kavon
force-pushed
the
noncopyable-generics-pt3
branch
from
948654f to
6fe00b6
Compare
With the growing popularity of using Features, I think it's important to ensure our Features querying set is as fast as possible. In particular, we sometimes may end up putting a feature check in a hot function, so the `contains` overhead is important. While I haven't done *any* measurements to verify this, I think a `llvm::SmallSet<Feature, 2>` is slower than a FixedBitSet. For the former, if the set grows more than the constant size, it switches over to using a `std::set`. Setting the size to `numFeatures()` is not particularly attractive or possible, because `SmallSet` is limited to a size of 32 to be considered small, as it uses linear search over a SmallVector to service a `contains` query. Meanwhile, a FixedBitSet has a small constant factor overhead for querying if the element is contained: two divisions by a constant power-of-two, a bit shift, and a memory-read / compare. I think that'll beat a SmallSet in all cases.
kavon
requested review from
jckarter
and removed request for
xedin,
slavapestov and
hborla
|
@swift-ci please test |
|
@swift-ci Please test compiler performance |
1 similar comment
|
@swift-ci Please test compiler performance |
|
@swift-ci please smoke test and merge |
This was referenced Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some bug fixes and refactoring to start testing NoncopyableGenerics end-to-end.