Revert "[NoncopyableGenerics] Basic end-to-end testing (without stdlib)." #69649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
I think we only need to revert this commit: 6fe00b6 |
kavon
requested changes
Nov 4, 2023
There was a problem hiding this comment.
Here's a PR to just remove the failing test: #69655
I know what the issue is but it'll take more fixes; the SILLinker likes to link stuff from the stdlib that I wasn't expecting it to on Windows and Linux, which is what's creating the difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #69591
This seems to be causing a test failure on Windows. It seems that the CI merged the change without waiting for completion or could be a timeout thing as there was a GH outage.