[ASTGen] Protect parseASTFromSyntaxTree for SWIFT_BUILD_SWIFT_SYNTAX #69858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drodriguez
requested review from
ahoppen,
bnbarham,
CodaFi,
DougGregor and
rintaro
as code owners
|
@swift-ci please test |
|
Ah, thank you! |
rintaro
approved these changes
Nov 14, 2023
|
Reading https://github.com/apple/swift/pull/69761/files#r1392952571 I decided to un-guard the field in |
|
I would prefer you to do that change, if you don't mind. I think I understand the intention of the variable and which one should be its value, but you probably know better. There's an extra error (missing semicolon in one of the |
The field `IsForASTGen` only exists when `SWIFT_BUILD_SWIFT_SYNTAX` is defined, but the usage was unprotected. The whole function can be inside the protected block because it only seems to be invoked from inside blocks already protected by `SWIFT_BUILD_SWIFT_SYNTAX`. Fix for swiftlang#69761
drodriguez
force-pushed
the
ifdef-parse-bridging
branch
from
0dbf8c0 to
0aca872
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field
IsForASTGenonly exists whenSWIFT_BUILD_SWIFT_SYNTAXis defined, but the usage was unprotected. The whole function can be inside the protected block because it only seems to be invoked from inside blocks already protected bySWIFT_BUILD_SWIFT_SYNTAX.Fix for #69761