Skip to content

[Parse] Unguard Parser.IsForASTGen for SWIFT_BUILD_SWIFT_SYNTAX #69877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2023
Merged

[Parse] Unguard Parser.IsForASTGen for SWIFT_BUILD_SWIFT_SYNTAX #69877

merged 1 commit into from
Nov 15, 2023

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Nov 15, 2023 •
edited
Loading

Hiding a field depending on -D was not a good idea. e.g. #69858 #69761 (comment)

cc: @drodriguez

@rintaro
[Parse] Unguard Parser.IsForASTGen for SWIFT_BUILD_SWIFT_SYNTAX
e5472ad 
Changing a field depending on `-D` was not a good idea.
@rintaro
Copy link
Member Author

rintaro commented Nov 15, 2023

@swift-ci Please smoke test

1 similar comment
@rintaro
Copy link
Member Author

rintaro commented Nov 15, 2023

@swift-ci Please smoke test

@rintaro rintaro merged commit 23effda into swiftlang:main Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

@ahoppen ahoppen Awaiting requested review from ahoppen

@CodaFi CodaFi Awaiting requested review from CodaFi CodaFi is a code owner

@DougGregor DougGregor Awaiting requested review from DougGregor DougGregor is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @bnbarham