[android] Update to LTS NDK 26c #69908
Conversation
stdlib/private/SwiftPrivateLibcExtras/SwiftPrivateLibcExtras.swift
Outdated
Show resolved
Hide resolved
| @@ -61,7 +61,7 @@ SWIFT_READONLY | |||
| static inline int _swift_stdlib_memcmp(const void *s1, const void *s2, | |||
| __swift_size_t n) { | |||
| // FIXME: Is there a way to identify Glibc specifically? | |||
| #if defined(__gnu_linux__) | |||
| #if defined(__gnu_linux__) || defined(__ANDROID__) | |||
There was a problem hiding this comment.
This is the only line that will break the last NDK 25c, as there's no way to check the NDK version without including headers like sys/cdefs.h, which this header doesn't include.
|
Ran the compiler validation suite natively with NDK 26b also now, works well, though more C++ Interop tests may break with the new NDK. @drodriguez, let me know. |
|
As explained in #70174 (comment) you might need to live with the existing NDK for the time being until another Android Community CI is available. I do not have time to install and test new pieces in the existing machines. |
|
Alright, understood. |
|
@kateinoigakukun, please run the CI here. |
|
@swift-ci Please smoke test |
|
Mac CI failed at checkout. |
|
@swift-ci smoke test macOS platform |
|
@bnbarham, the mac CI was broken a couple weeks ago, please run it again now. |
|
@swift-ci please test |
|
Heh, now the Windows CI failed at source checkout. |
|
@swift-ci please test Windows platform |
NDK 26 renamed the directory in which it places the Android compiler-rt from `lib64/`, and added a bunch of nullability annotations to the Bionic libc.
|
@compnerd, removed the breaking change in |
finagolfin
changed the title
|
@swift-ci please test |
NDK 26 renamed the directory in which it places the Android compiler-rt from
lib64/, and added a bunch of nullability annotations to the Bionic libc.@drodriguez, please review. You'll need to update the NDK on the community CI and this will likely break some tests in the compiler validation suite, which I haven't tried with NDK 26b yet. I will submit a separate pull to fix any tests once this is in.