[android] Update memcmp() declaration for nullability annotations added in NDK 26
#71968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
compnerd
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked again if this builds with NDK 25c and the stdlib built fine, so I enabled it for both NDK 25 and 26 on my Android CI, finagolfin/swift-android-sdk#132, and saw that it only breaks building with swift-corelibs-foundation for 25c. I had seen that this is a breaking change for earlier Android NDKs, so I spun this off from #69908 so it wouldn't break the community Android CI that uses the previous NDK 25, but that CI only builds the Android stdlib so it may be fine.
@drodriguez, let me know what you think about getting this in now, as the community Android CI has been broken because of the swift-syntax issues anyway.