Treat package as resilient as non-frozen public by default #70141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
CodaFi
reviewed
Nov 30, 2023
|
@swift-ci smoke test |
elsh
changed the title
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
CodaFi
reviewed
Jan 12, 2024
xymus
reviewed
Jan 17, 2024
xymus
reviewed
Jan 17, 2024
elsh
commented
Jan 18, 2024
test/IRGen/package_resilience.swift
Outdated
| // CHECK: @"$s18package_resilience26ClassWithResilientPropertyC1p16resilient_struct5PointVvpWvd" = constant [[INT]] {{8|16}}, align [[#WORDSIZE]] | ||
| // CHECK: @"$s18package_resilience26ClassWithResilientPropertyC1s16resilient_struct4SizeVvpWvd" = constant [[INT]] {{32|16}}, align [[#WORDSIZE]] | ||
| // CHECK: @"$s18package_resilience26ClassWithResilientPropertyC1p16resilient_struct5PointVvpWvd" = hidden global [[INT]] 0, | ||
| // CHECK: @"$s18package_resilience26ClassWithResilientPropertyC1s16resilient_struct4SizeVvpWvd" = hidden global [[INT]] 0, |
There was a problem hiding this comment.
FYI I get hidden global for a public decl as well, with or without this PR.
For example,
public struct PublicSize {
public var w: Int // should have getter and setter
public let h: Int // getter only
public init(w: Int, h: Int) {
self.w = w
self.h = h
}
public func method() {}
public mutating func mutantMethod() {}
}
referenced in
public class PublicClassWithPbProperty {
public let p: PublicPoint
public let s: PublicSize
public let color: Int32
public init(p: PublicPoint, s: PublicSize, color: Int32) {
self.p = p
self.s = s
self.color = color
}
}
results in
@"$s18package_resilience25PublicClassWithPbPropertyC1p16resilient_struct0C5PointVvpWvd" = hidden global i64 0, align 8
|
@swift-ci smoke test |
If the defining module is built resiliently, treat the package decl as resilient, just as we do for public decls. Access methods to `package` should be the same as for non-frozen `public`, i.e. indirect. Added tests for SIL/IR wrt serialization and indirect access with/out resilience enabled. Resolves rdar://118947451
|
@swift-ci smoke test |
|
@swift-ci smoke test linux |
elsh
changed the title
xymus
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
packagetypes are treated non-resilient by default. This PR changes that to treat them asresilient as non-frozen
publicby default. If the defining module is built resiliently, treat the packagedecl as resilient, just as we do for
publicdecls. Access methods topackageshould be the sameas for non-frozen
public, i.e. indirect.Added tests for SIL/IR wrt serialization and indirect access with/out resilience enabled.
Resolves rdar://118947451