Change effectiveAccessLevel of package decls from public to package.
#70897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsh
requested review from
xymus,
beccadax,
CodaFi,
artemcm,
tshortli and
nkcsgexi
and removed request for
slavapestov
|
@swift-ci smoke test |
|
Pending #70141 |
|
I see no test cases added for this change. Is that because this is a NFC refactoring for the next PR? |
Updates to existing tests are added. |
elsh
changed the title
package decls from public to package.package decls from public to package.
xymus
reviewed
Jan 17, 2024
|
@swift-ci smoke test |
CodaFi
approved these changes
Jan 23, 2024
|
@swift-ci smoke test |
elsh
changed the title
package decls from public to package.package decls from public to package.
xymus
approved these changes
Jan 23, 2024
access level for optimization: `public`. It requires an extra check for the actual access level that was declared when determining serialization since the behavior should be different. This PR sets its effective access level to `package` as originally defined, updates call sites to make appropriate acces level comparisons, and removes `package` specific checks.
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently decls defined with
packageaccess level have a different access level for optimization:public. It requires an extra check for the actual access level that was declared when determining serialization since the behavior should be different.This PR sets its effective access level to
packageas originally defined, updates call sites to make appropriate acces level comparisons, and removespackagespecific checks.Resolves rdar://121470986