[Concurrency] Downgrade missing await error to a warning for synchronous access to isolated global/static lets.
#70151
+82
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onous access to isolated global and static variables that are lazily initialized.
hborla
requested review from
ktoso,
kavon,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
hborla
commented
Dec 1, 2023
| /// the var is read. | ||
| bool isLetAccessibleAnywhere(const ModuleDecl *fromModule, | ||
| VarDecl *let, | ||
| ActorReferenceResult::Options &options); |
There was a problem hiding this comment.
Note that I added this as a new overload because the original is in include/swift/AST/ActorIsolation.h and I didn't see a good reason to expose ActorReferenceResult outside of Sema.
ktoso
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiler versions <5.10 allowed this code, so the error should be staged in as a warning until Swift 6.
The only effect checker diagnostics downgraded by this change are the ones introduced in #69607.