[5.10][Concurrency] Downgrade missing await error to a warning for synchronous access to isolated global/static lets.
#70179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
…onous access to isolated global and static variables that are lazily initialized. (cherry picked from commit 61b43e6)
hborla
force-pushed
the
5.10-downgrade-missing-await-error
branch
from
34f6c0a to
9cb2873
Compare
|
@swift-ci please test |
airspeedswift
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
static lets are not safe to access across actors. #69607 fixed an issue where lazily initialized global and static variables with global actor isolation could be accessed synchronously from outside the actor. This caused the effects checker to diagnose missingawaiterrors for synchronous access to such variables inasynccontexts. Compiler versions <5.10 allowed this code, so the error should be staged in as a warning until Swift 6.static lets are not safe to access across actors. #69607.awaiterror to a warning for synchronous access to isolated global/staticlets. #70151. Note that the change in TypeCheckEffects.cpp is slightly different than themainversion because effects checking has been refactored onmainfor the typed throws implementation.