SimplifyBeginCOWMutation: don't eliminate end_cow_mutation instructions with the [keep_unique] flag
#70233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci benchmark |
eeckstein
force-pushed
the
fix-cow-simplification
branch
from
eddc4ed to
0574610
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test linux |
…ions with the `[keep_unique]` flag This flag is important for following optimizations. Therefore such `end_cow_mutation` instructions must not be removed. Also, keep the flag in a SILCombine transformation. rdar://119178823
eeckstein
force-pushed
the
fix-cow-simplification
branch
from
0574610 to
c829d5b
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag is important for following optimizations. Therefore such
end_cow_mutationinstructions must not be removed.rdar://119178823