Unrevert #69450 - Add a mark_dependence while emitting SIL for uninitialized array allocation #70242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please Build Toolchain |
|
@swift-ci test |
|
I'll merge this once #70233 is merged. |
meg-gupta
force-pushed
the
unrevertarrayfix
branch
from
16693e3 to
e685b24
Compare
|
@swift-ci smoke test |
meg-gupta
added a commit
to meg-gupta/swift
that referenced
this pull request
Feb 27, 2024
With swiftlang#70242 mark_dependence was added while emitting uninitialized array allocation between the unsafe pointer and the array value returned. Without it, we can end up with use after free of the unsafe pointer if the array's lifetime is shortened. Along with this change, pattern matching of all array optimizations was updated to include mark_dependence. This change adds mark_dependence for uninitialized array allocation in OSLogOptimization which was left out previously. With this, potential use-after-free of the unsafe pointer is prevented and all updated array optimizations apply to the array created by OSLogOptimization. Fixes rdar://122922902
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently allocation for uninitialized array looks like this:
There is no lifetime dependence between the interior pointer and the array value returned by such functions. This can cause illegal lifetime shortening.
Add a mark_dependence and teach the new array initialization pattern to the optimizer.
Fixes rdar://114546034
#69450 was reverted because it exposed an unrelated optimizer problem - rdar://117927523