Skip to content

[Concurrency] Key paths and global actors #70285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 8, 2023

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Dec 7, 2023

  • InferSendableFromCaptures: If key path references a global actor isolated member mark it as non-Sendable
  • Diagnose use of the global actor isolated members if the access and declaration
    concurrency domains differ. (This is a warning until Swift 6).

Resolves: #66830
Resolves: rdar://117538832

@xedin
Copy link
Contributor Author

xedin commented Dec 7, 2023

@swift-ci please test

@xedin xedin force-pushed the keypath-with-global-actors branch from e8a0890 to 05dc4b5 Compare December 7, 2023 18:50
@xedin
Copy link
Contributor Author

xedin commented Dec 7, 2023

@swift-ci please test

xedin added 2 commits December 7, 2023 15:41
…s in key paths

If key path is formed in a concurrency domain different from the
one where the member is, diagnose that as a warning until Swift 6.
@xedin xedin force-pushed the keypath-with-global-actors branch from 05dc4b5 to e561ac4 Compare December 7, 2023 23:41
@xedin
Copy link
Contributor Author

xedin commented Dec 7, 2023

@swift-ci please test

Copy link
Member

@hborla hborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@xedin
Copy link
Contributor Author

xedin commented Dec 8, 2023

@swift-ci please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyPath discards global actor
2 participants