[5.10][Concurrency] Start diagnosing use of global actor isolated propertie… #70329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in key paths in strict mode If key path is formed in a concurrency domain different from the one where the member is, diagnose that as a warning in a strict mode and error in swift 6 mode with strict concurrency enabled.
|
@swift-ci please test |
hborla
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s in key paths in strict mode
Partial cherry-pick of #70285
Start diagnosing use of global actor isolated properties in key paths in strict mode.
If key path is formed in a concurrency domain different from the one where the member is,
diagnose that as a warning in a strict mode and error in swift 6 mode with strict concurrency enabled.
Scope: Key path expressions that refer to global actor-isolated members in
completestrict concurrency mode.Main Branch PR: [Concurrency] Key paths and global actors #70285
Resolves: rdar://117538832
Risk: Low
Reviewed By: @hborla
Testing: Added test-cases to the test suite.