Skip to content

build: Explicitly set SWIFT_ENABLE_DISPATCH to build Wasm stdlib #70511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2024
Merged

build: Explicitly set SWIFT_ENABLE_DISPATCH to build Wasm stdlib #70511

merged 1 commit into from
Jan 18, 2024

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Dec 16, 2023 •
edited
Loading

Stdlib build depends on SWIFT_ENABLE_DISPATCH to select concurrency global executor implementation since ed8ed32

The change broke the wasm stdlib build because wasmstdlib product used default value of SWIFT_ENABLE_DISPATCH=YES

CMake Error at stdlib/cmake/modules/StdlibOptions.cmake:225 (message):
  Concurrency requires libdispatch on non-Darwin hosts.  Please specify
  SWIFT_PATH_TO_LIBDISPATCH_SOURCE
Call Stack (most recent call first):
  stdlib/CMakeLists.txt:59 (include)

https://github.com/swiftwasm/swiftwasm-build/actions/runs/7231861263/job/19705503571#step:14:1976

@kateinoigakukun
build: Explicitly set SWIFT_ENABLE_DISPATCH to build Wasm stdlib
7a80418 
Stdlib build depends on `SWIFT_ENABLE_DISPATCH` to select concurrency
global executor implementation since ed8ed32
@kateinoigakukun
Copy link
Member Author

preset=buildbot_linux_crosscompile_wasm
@swift-ci Please test with preset Linux Platform

1 similar comment
@MaxDesiatov
Copy link
Contributor

preset=buildbot_linux_crosscompile_wasm
@swift-ci Please test with preset Linux Platform

@MaxDesiatov
Copy link
Contributor

@swift-ci test

@MaxDesiatov MaxDesiatov added standard library Area: Standard library umbrella cmake WebAssembly Platform: WebAssembly labels Dec 26, 2023
@kateinoigakukun
Copy link
Member Author

preset=buildbot_linux_crosscompile_wasm
@swift-ci Please test with preset Linux Platform

@kateinoigakukun
Copy link
Member Author

@swift-ci Please test

@kateinoigakukun
Copy link
Member Author

kateinoigakukun commented Jan 17, 2024 •
edited
Loading

The failure will be fixed by another patch #70959

Failed Tests (1):
  Swift(wasi-wasm32) :: IRGen/static-vtable-stubs.swift


Testing Time: 3.76s
  Unsupported      : 541
  Passed           : 336
  Expectedly Failed:   3
  Failed           :   1

@kateinoigakukun kateinoigakukun merged commit a225643 into swiftlang:main Jan 18, 2024
@kateinoigakukun kateinoigakukun deleted the katei/fix-global-executor-selection-wasm branch January 18, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
cmake standard library Area: Standard library umbrella WebAssembly Platform: WebAssembly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kateinoigakukun @MaxDesiatov