[test][IRGen] Fix static-vtable-stubs.swift on wasm32 #70959
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was failing on 32-bit targets because of the different size of
`dereferenceable` attribute.
```
B.swift:37:11: error: CHECK: expected string not found in input
// CHECK: declare swiftcc { ptr, ptr } @"$s1M1CC1i33_807E3D81CC6CDD898084F3279464DDF9LLSDySOypGvM"(ptr noalias dereferenceable(32), ptr swiftself) #0
^
<stdin>:125:1: note: possible intended match here
declare swiftcc { ptr, ptr } @"$s1M1CC1i33_807E3D81CC6CDD898084F3279464DDF9LLSDySOypGvM"(ptr noalias dereferenceable(16), ptr swiftself) #0
```
The size of coroutine buffer passed as the first argument to the
"modify" coroutine function is dependent on the target pointer size.
(it's calculated as `NumWords_YieldOnceBuffer` * sizeof(void*)`).
The size is out of the scope of the test, so just accept any size.
|
preset=buildbot_linux_crosscompile_wasm |
|
preset=buildbot_linux_crosscompile_wasm |
|
@swift-ci Please smoke test |
|
I already have a fix for this in #70929, can you check if that would work instead? |
|
@finagolfin The test fix is almost identical to yours, but the CMake change seems arguable. I want to merge this PR to unblock our CI first, and the CMake change should be discussed in your PR. Does that sound reasonable for you? |
|
Can you hold off for a day? I think my pull will go in today and be more general. This test has been broken on 32-bit for a month now, don't think waiting another day will hurt. |
|
@finagolfin Okay, I understood |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was failing on 32-bit targets because of the different size of
dereferenceableattribute.The size of coroutine buffer passed as the first argument to the "modify" coroutine function is dependent on the target pointer size. (it's calculated as
NumWords_YieldOnceBuffer* sizeof(void*)`).The size is out of the scope of the test, so just accept any size.