Fix the SIL type equality assert failures due to opaque return types. #70865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We encountered several SIL type equality assert failures in our internal app and reduced them into the included test. The issue seemed to be that some places have the opaque return type and other places have the opaque types' underlying types and the type equality asserts fail. This change adds some logic to replace the opaque types with their underlying types, absorb the differences and avoid the assert failures.
|
The reduced test case is valuable but simply loosening assertions is rarely the correct fix. We ought to understand if the opaque return types are not being properly substituted elsewhere. |
|
@slavapestov Do you have any suggestions where to look, some tests to run, or something on how to check that the opaque return types are properly substituted? I don't currently have a great sense of what may need to happen somewhere. |
|
The issue was fixed by 8d649a2 |
|
@hjyamauchi Your test case is still valuable though. Do you mind putting up a PR with just the new test? |
|
@slavapestov Assuming you mean just the test part from this PR (which is fixed by 8d649a2), yeah I will. |
hjyamauchi
added a commit
to hjyamauchi/swift
that referenced
this pull request
Jan 26, 2024
…turn types. This is the test part of swiftlang#70865 which was fixed by the commit swiftlang@8d649a2
|
Created this PR for the test: #71187 |
hjyamauchi
added a commit
to hjyamauchi/swift
that referenced
this pull request
Jan 29, 2024
…turn types This is the test part of swiftlang#70865 which was fixed by the commit swiftlang@8d649a2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encountered several SIL type equality assert failures in our internal app and reduced them into the included test.
The issue seemed to be that some places have the opaque return type and other places have the opaque types' underlying types and the type equality asserts fail. This change adds some logic to replace the opaque types with their underlying types, absorb the differences and avoid the assert failures.