Adopt typed throws in one withUnsafePointer() API #70971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubamracek
requested review from
phausler,
stephentyrone,
DougGregor,
rauhul,
zoecarver and
eeckstein
|
@swift-ci please test |
glessard
approved these changes
Jan 17, 2024
DougGregor
approved these changes
Jan 17, 2024
| @inlinable | ||
| public func withUnsafePointer<T, E, Result>( | ||
|
|
||
| /// ABI: Historical withUnsafePointer(to:_:) rethrows, expressed as "throws", |
There was a problem hiding this comment.
Should this be in a #if !$Embedded block, since there is no ABI to maintain?
There was a problem hiding this comment.
I wonder if we shouldn't put all these legacy untyped-throws implementations in a file that we can simply not build for non-ABI or new platforms.
There was a problem hiding this comment.
I'll leave this is it is in this PR, if you're okay with that, but yes, we want to decide how to organize the legacy implementations. I don't feel strongly about this, but let me just note that there is no impact for Embedded Swift even if we keep the legacy impl in -- unused functions do not contribute to binary outputs.
|
@swift-ci please test |
stephentyrone
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.