Refactor conformance checker diagnostics #71041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntsAreSatisfied()
slavapestov
requested review from
AnthonyLatsis,
hborla,
xedin and
CodaFi
as code owners
|
@swift-ci Please test source compatibility |
slavapestov
force-pushed
the
refactor-conformance-checker-diagnostics
branch
from
f2a7222 to
76d9805
Compare
slavapestov
force-pushed
the
refactor-conformance-checker-diagnostics
branch
from
76d9805 to
0bc2e3f
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves delayed diagnostics state entirely out of ConformanceChecker. The goal is to decouple type witness inference from ConformanceChecker, leaving it in charge of value witness inference only. This will in turn lead to better request evaluator usage in type witness inference.
This also fixes a case where we accepted invalid AST because a protocol conformance check failed in a secondary source file. We now emit a fallback diagnostic
type T does not conform to protocol Pin this case. The source location is chosen to be that of the innermost active request that refers to a primary file; if no active requests have such a location, we use the location of the conformance instead.With a few more cleanups this will allow removing the older
reference to invalid associated typefallback diagnostic, which is inaccurate because it misses cases where the invalid type witness ends up in a substitution map, or if the type witness is valid but does not satisfy an associated conformance requirement.