Sema: Decouple type witness resolution from the ConformanceChecker #71131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yedConformanceDiag()
slavapestov
requested review from
AnthonyLatsis,
hborla,
ktoso and
xedin
as code owners
slavapestov
force-pushed
the
conformance-checker-vs-type-witnesses-untangling
branch
from
4f3f156 to
979fc28
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #71041 and #71058 .
The conformance checker had an extremely convoluted scheme for tracking diagnostics and missing witnesses that can only be described as a complex state machine. This PR greatly simplifies this mechanism. This allows moving type witness resolution out of the ConformanceChecker.
This removes
ProtocolConformanceState::CheckingTypeWitnesses, which was added with commit 161f309 back in 2015 (!) by none other than @DougGregor himself.